Skip to content

Conversation

@davidrohr
Copy link
Contributor

@davidrohr davidrohr commented Aug 6, 2019

Fix usage of YAML-CPP include dirs, when they are in /usr/include.
Otherwise, CMake will add -isystem /usr/[SOMETHING]/../include to the gcc command line, which breaks GCC for some known weird reason.


Checklist:

@dennisklein dennisklein changed the base branch from master to dev August 6, 2019 17:19
@dennisklein
Copy link
Member

@davidrohr It wouldn't let me force push to your branch. If you give me a thumbs up in #911, I will merge that, or if you want to get my changes from my fork (branch davidrohr_PR2) in this PR, I can merge this one. However you prefer :) Thx for the contrib!

@davidrohr
Copy link
Contributor Author

Weird, it is definitely marked as "allow edits from maintainers", no idea what is the problem.

@dennisklein
Copy link
Member

"allow edits from maintainers", no idea what is the problem.

Had this problem many times in the past with Alexey too. It seems to be depending on some additional condition, maybe we need to be member of the same org or just force-pushes are not possible or the checkbox needs to be checked right away? sometimes it works for me, sometimes not..

@dennisklein dennisklein closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants