Simulation split #849
Closed
Simulation split #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbx
reviewed
Nov 13, 2018
Collaborator
Author
|
I guess you mean the if (1==0).
tldr: it should show the end user possible features.
in principle you are right.
I got the piece of code when I copied from pixelDetector/run/runMQSim.cxx
where you would probably ask exactly the same question (I am the author of that code either).
The lines included in the if will be immediately clear to anyone who is running any simulations in FairRoot/PandaRoot/Cbmroot.
It simply shows the user, that s/he can attach to FairMQSimDevice or FairMQTransportDevice
any FairTask that s/he may deem necessary to run together with the particle transport.
It is sometimes necessary, but in FairRoot's simple detector examples is not needed.
yours,
radek
… On 13. Nov 2018, at 17:02, Alexey Rybalchenko ***@***.***> wrote:
@rbx commented on this pull request.
In examples/MQ/simulation_split/run/runMQTrans.cxx <#849 (comment)>:
> + run->SetTransportName (config.GetValue<std::string>("transport-name"));
+ run->SetMaterials ("media.geo");
+
+ TObjArray* detArray = new TObjArray();
+ FairModule* cave= new FairCave("CAVE");
+ cave->SetGeometryFileName("cave_vacuum.geo");
+ detArray->Add(cave);
+ // Pixel* det = new Pixel("PixelDetector", kTRUE);
+ // det->SetGeometryFileName("pixel.geo");
+ // detArray->Add(det);
+ run->SetDetectorArray (detArray);
+
+ run->SetStoreTraj (false);
+
+ // ---------------------------------------------------
+ if ( 1==0 )
why do you need this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#849 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGHFJlSXET_j2A0oIUMrV5_NfFmc6Xvtks5uuu0VgaJpZM4Yb52u>.
|
Member
Perhaps you can hide it behind a cmd argument that is off by default, then it is easily usable without recompiling |
karabowi
force-pushed
the
simulation_split
branch
from
bd9b8cf to
d8e2782
Compare
karabowi
force-pushed
the
simulation_split
branch
from
75c4841 to
d909253
Compare
Member
|
Hi, a rebase against current |
First version of the MC simulation in MQ, where generated events are sent to transport devices: - FairMQPrimaryGeneratorDevice - generates events and pushes them; - FairMQTransportDevices - pulls generated events and transports them in G3 or G4; - FairGenericStack/FairStack - added new function SetParticleArray(); - FairMQRunDevice - base class for FairMQSimDevice.
Replaced usage of TMessage with RootSerializer. Added possibility to run in different regime: - generator pushes the data, transporter pulls the data (default); - transporter requests data, generator replies with the data (new). Added script to run the example in DDS.
PixelFileSink now stores all the data that arrive in the message. Obsolete method my specifing data to store via command line interface removed.
Restructed the simulation_split example. - FairMQPrimaryGeneratorDevice - now can split simulated events into chunks; - FairMQTransportDevice - transports full or chunk of simulated events; - FairMQChunkMerger - merges chunks of individual events into full events;
Moving from TMessage to RootSerializer.
pixelDetector - further replacement of TMessage with RootSerializer. simulation_split - reducing verbosity.
TransportDevice gets the RunId from the parameter server.
MQ/simulation_split/runMQTrans.cxx lets user specify detector libraries; MQ/simulation_split/FairMQTransportDevice loads libraries requested by user and executes extern C ExternCreateDetector() function, which adds specific detector to FairRunSim; MQ/pixelDetector/Pixel.cxx simulation/Tutoria1/FairTutorialDet1.cxx - introduced the extern C ExternCreateDetector() function;
Added DDS topology. Added options to change channel names of the FairMQChunkMerger. Polishing of FairMQPrimaryGeneratorDevice.
Added test that runs in DDS.
Modified tests to be more general: - checking if enough agents started; - checking for output file size before stopping; - using dds session id to connect to correct one.
Fixed some codacy issues. Fixed running the test.
Disabled validation for the xml config file for DDS.
Removed obsolete directory.
Fixed test output directory. It should not write to source, only to build.
Moved the test from dds-server to dds-session. Checking devices status before finishing.
Load FairRoot's config.sh environment for the Transporter task.
Added test in pure MQ.
karabowi
force-pushed
the
simulation_split
branch
from
dadc008 to
d3742fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQ/examples/simulation_split
First version of the MC simulation in MQ, where
generated events are sent to transport devices.
Checklist:
devbranch