Arc BUILD system and reliability improvements #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ introduced a cmake build system to handle installation for spack
+ introduced more robust linking for library dependencies
+ in-lined the parity matrices and syndrome tables to remove need to
load/install them at runtime
+ cache_resource_location where runtime files are stored now defaults to
one of the following locations in order from greatest priority rather
than a hard coded path that would not exist after installation:
+ ${XDG_RUNTIME_DIR}/arc
+ ${TMPDIR}/arc
+ /tmp
+ fixed undefined behavior in arc_reed_soloman_encode
+ removed broken makefiles that always required manual editing
Known bugs:
+ in some yet to be determined circumstances, ARC will fail to select a
configuration resulting arc_configurations[i].ecc_algorithm to be 0
resulting in a unsigned underflow on line 930 of arc.c (possibly also
other places). Additional work needs to be done to identify why this
occurs and how to properly fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joncalhoun40 @dkfulp
load/install them at runtime
one of the following locations in order from greatest priority rather
than a hard coded path that would not exist after installation:
Known bugs:
configuration resulting arc_configurations[i].ecc_algorithm to be 0
resulting in a unsigned underflow on line 930 of arc.c (possibly also
other places). Additional work needs to be done to identify why this
occurs and how to properly fix it.