Skip to content

Improvements to links in external objects table#171

Open
alahiff wants to merge 3 commits intomainfrom
external_object_links
Open

Improvements to links in external objects table#171
alahiff wants to merge 3 commits intomainfrom
external_object_links

Conversation

@alahiff
Copy link
Copy Markdown
Collaborator

@alahiff alahiff commented Oct 12, 2021

At the moment using the file symbol because the nice info symbol is only in the pro version of font awsome. If anyone has any alternative preferences (see https://fontawesome.com/v5.15/icons?d=gallery&p=2) please let me know.

@alahiff alahiff linked an issue Oct 12, 2021 that may be closed by this pull request
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 12, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.87%. Comparing base (0570eaa) to head (8015b0b).
⚠️ Report is 314 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   58.87%   58.87%           
=======================================
  Files          20       20           
  Lines        1223     1223           
=======================================
  Hits          720      720           
  Misses        503      503           
Flag Coverage Δ
unittests 58.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alahiff
Copy link
Copy Markdown
Collaborator Author

alahiff commented Oct 12, 2021

We could also do the same for data products (link is now on the name) and code repo releases (link also on the name) so that everything is consistent.

@alahiff
Copy link
Copy Markdown
Collaborator Author

alahiff commented Oct 12, 2021

This is what it currently looks like:
image

@agbeltran agbeltran requested a review from antony-wilson March 16, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't use Alternate Identifier as link to external object details

1 participant