Skip to content

Improve adt test and file structure#2371

Merged
timfelle merged 28 commits intoExtremeFLOW:developfrom
timofeymukha:test/more_unit_tests
Mar 19, 2026
Merged

Improve adt test and file structure#2371
timfelle merged 28 commits intoExtremeFLOW:developfrom
timofeymukha:test/more_unit_tests

Conversation

@timofeymukha
Copy link
Copy Markdown
Collaborator

Dep #2370

Improves tests for types under src/adt. Some types were not tested at all, some additional tests added for others. Sparse comments on what is tested added.

In the type modules themselves, public is stripped from type definitions instead a list of public : type_name is arranged at the top, declaring the data type inside as a comment. This makes it much easier to find the concrete type necessary for data at hand.

@timofeymukha timofeymukha added the enhancement New feature or request label Mar 10, 2026
@njansson
Copy link
Copy Markdown
Collaborator

Style comments aside (I'm in favour of having public at the type declaration), I do recall that certain compilers can't declare things public before they are declared, thus this long list has to be moved to before contains, which kind of beats the purpose here.

@timofeymukha
Copy link
Copy Markdown
Collaborator Author

Style comments aside (I'm in favour of having public at the type declaration), I do recall that certain compilers can't declare things public before they are declared, thus this long list has to be moved to before contains, which kind of beats the purpose here.

OK, I refactored to having tables in the module level docstrings. i would really like to hava quick lookup of the types somewhere

@timfelle timfelle enabled auto-merge March 19, 2026 07:47
@timfelle timfelle added this pull request to the merge queue Mar 19, 2026
Merged via the queue into ExtremeFLOW:develop with commit 742aedd Mar 19, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants