Improve adt test and file structure#2371
Merged
timfelle merged 28 commits intoExtremeFLOW:developfrom Mar 19, 2026
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
|
Style comments aside (I'm in favour of having public at the type declaration), I do recall that certain compilers can't declare things |
Collaborator
Author
OK, I refactored to having tables in the module level docstrings. i would really like to hava quick lookup of the types somewhere |
njansson
approved these changes
Mar 17, 2026
timfelle
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dep #2370
Improves tests for types under src/adt. Some types were not tested at all, some additional tests added for others. Sparse comments on what is tested added.
In the type modules themselves,
publicis stripped from type definitions instead a list ofpublic : type_nameis arranged at the top, declaring thedatatype inside as a comment. This makes it much easier to find the concrete type necessary for data at hand.