Skip to content

Fix rig lint conflict marker false positives#7626

Merged
chubes4 merged 1 commit into
mainfrom
fix/rig-lint-conflict-marker-false-positive
Jul 6, 2026
Merged

Fix rig lint conflict marker false positives#7626
chubes4 merged 1 commit into
mainfrom
fix/rig-lint-conflict-marker-false-positive

Conversation

@chubes4

@chubes4 chubes4 commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Fix rig package lint false positives where vendored dependency files and fixture/banner content were reported as unresolved conflict markers during Lab/offloaded rig check pipelines.
  • Exclude standard dependency/generated directories from generic rig package lint traversal.
  • Tighten conflict-marker detection to require a real Git conflict block shape instead of any line containing marker-like separators.

Details

The Lab offload SSI fixture matrix hit false unresolved-conflict-marker findings in paths like vendor/psr/event-dispatcher/README.md and transformer fixture CSS banners. Those are not source conflict markers: dependencies should not be source-linted, and banner/heading separator lines should not match unless they form an actual Git conflict block.

This keeps Homeboy core product-agnostic by using generic directory conventions and precise Git marker parsing, with no SSI-specific paths.

Verification

  • cargo test core::rig::lint
  • cargo build
  • cargo clippy --all-targets --all-features -- -D warnings (fails on existing unrelated repo-wide clippy warnings outside this change; no failures from src/core/rig/lint.rs)

Tests

  • CSS banner comments and Markdown heading/separator lines are not flagged.
  • Vendored README content under vendor/ is not scanned.
  • A real <<<<<<< / ======= / >>>>>>> conflict block is still flagged.

AI assistance

  • AI assistance: Yes
  • Tool(s): opencode with Claude Fable 5 orchestrator and GPT-5.5 subagents
  • Used for: Diagnosing the rig conflict-marker lint false-positive, implementing the generic heuristic/exclusion fix, and drafting tests/PR notes.

@homeboy-ci

homeboy-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — homeboy

Lint

review lint — passed

ℹ️ Full options: homeboy self docs commands/lint
ℹ️ Save lint baseline: homeboy review lint homeboy --baseline
Deep dive: homeboy review lint homeboy --changed-since df337e4

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-homeboy-review-lint-homeboy-Linux contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-homeboy-review-lint-homeboy-Linux contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/homeboy/actions/runs/28800910448

Audit

review audit — passed

  • structural — 28 finding(s)
  • field_patterns — 16 finding(s)
  • core_boundary_leak:core-agnostic-source — 9 finding(s)
  • test_quality — 5 finding(s)
  • Types — 3 finding(s)
  • dead_code — 2 finding(s)
  • docs — 2 finding(s)
  • command_status_contracts — 1 finding(s)
  • compiler — 1 finding(s)
  • intra-method-duplication — 1 finding(s)
  • Total: 69 finding(s)

Deep dive: homeboy review audit homeboy --changed-since df337e4

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-homeboy-review-audit-homeboy-Linux contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-homeboy-review-audit-homeboy-Linux contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/homeboy/actions/runs/28800910448
Tooling versions
  • Homeboy CLI: homeboy 0.281.16+e0013f234ef0-dirty+e0013f234
  • Extension: rust from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 256c32b3
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 41d275a into main Jul 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant