Conversation
The composer lint:php/test scripts ran phpcs --standard=WordPress ., scanning the entire tree (2058 files) including vendor/ and node_modules/ and reporting thousands of third-party false positives. Add a phpcs.xml.dist that mirrors the homeboy release lint gate (WordPress-Extra with the same rule exclusions, vendor/build/node_modules excluded, testVersion 7.4-). The repo now scans 41 first-party files and passes clean (0 errors), matching the homeboy gate that governs releases. Point composer scripts at the config (drop the hardcoded --standard=WordPress .) and exclude phpcs.xml.dist from the build artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
homeboy release extrachilllint gate was reported as failing on pre-existing PHPCS errors. Investigation shows the homeboy release gate itself already passes clean (homeboy lint extrachill→ phpcs/eslint/phpstan all0findings, exit0) at the release commit. The "thousands of errors" come from the repo's owncomposer lint:phpscript, which ranvendor/bin/phpcs --standard=WordPress .— scanning the entire tree (2058 files, includingvendor/andnode_modules/). Those are third-party false positives, not first-party debt.This PR aligns the repo's own lint with the gate that actually governs releases.
What changed
phpcs.xml.distmirroring the homeboy release lint ruleset:WordPress-Extrawith the same rule exclusions homeboy uses (naming-convention + conflicting spacing sniffs).vendor/,node_modules/,build/,dist/,languages/.testVersion7.4-.composer.json:lint:php/lint:fix/testnow use the config file (dropped hardcoded--standard=WordPress .), so phpcs auto-discoversphpcs.xml.dist..buildignore: excludephpcs.xml.distfrom the release artifact (dev-only config).Result
composer lint:phpscopecomposer lint:phpresulthomeboy lint extrachillTriage notes (auto-fixed vs hand-fixed)
WordPressstandard (everything on) would flag ~120 first-party style items (docblock spacing, superglobal sanitization, etc.), but the homeboy release gate does not enforce those rule groups — so none of them block releases. Suppressing legitimate signal was avoided by mirroring the gate's ruleset exactly rather than inventing a looser one.phpcs.xml.distalready excludesvendor//node_modules//build/, so homeboy's lint scope is correct. The false positives lived in the repo's composer script, which this PR fixes at the repo level (per the task's Step 2b).Constraints honored