Skip to content

Fix artifact cleanup blocked-only completion#812

Merged
chubes4 merged 2 commits into
mainfrom
fix/artifact-cleanup-blocked-only-810
Jun 26, 2026
Merged

Fix artifact cleanup blocked-only completion#812
chubes4 merged 2 commits into
mainfrom
fix/artifact-cleanup-blocked-only-810

Conversation

@chubes4

@chubes4 chubes4 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary

  • Return a successful complete_with_blockers terminal state when artifact cleanup until-empty can only skip protected dirty/unpushed candidates.
  • Include blocker counts and reason summary on the terminal response.
  • Preserve no_progress for mixed or unexpected skip reasons.

Fixes #810.

Testing

  • php tests/cleanup-until-empty-blocked-only.php
  • php tests/artifact-cleanup-plan-output-contract.php
  • php tests/cleanup-remaining-work-summary.php
  • php -l inc/Workspace/CleanupRunService.php && php -l tests/cleanup-until-empty-blocked-only.php
  • Full for test in tests/*.php; do php "" || exit 0; done stopped at existing tests/worktree-metadata-reconciliation-finalizer-contract.php contract failure.

AI assistance

  • AI assistance: Yes
  • Tool(s): gpt-5.5 via OpenCode
  • Used for: Inspecting the cleanup runner behavior, implementing the blocked-only terminal state, adding the focused regression test, and running local verification.

@homeboy-ci

homeboy-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine-code --changed-since 8c4fa27

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/28209550898

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Save test baseline: homeboy test data-machine-code --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since 8c4fa27

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/28209550898

Audit

audit — passed

  • audit — 89 finding(s)
  • Total: 89 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since 8c4fa27

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/28209550898
Tooling versions
  • Homeboy CLI: homeboy 0.261.0+6ac880c96e78+d9d5bef
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 29799d56
  • Action: unknown@unknown

@chubes4
chubes4 merged commit f5e037a into main Jun 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make artifact cleanup until-empty distinguish blocked-only completion from failure

1 participant