Skip to content

Fix repeated GitHub issue list calls #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 1 commit into from
Jun 1, 2026
Merged

Fix repeated GitHub issue list calls #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions inc/Tools/GitHubTools.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,7 @@ public function handleListIssues( array $parameters, array $tool_def = array() )
*/
public function getListIssuesDefinition(): array
{
return $this->repeatableDefinition(
array(
return array(
'class' => __CLASS__,
'method' => 'handleListIssues',
'description' => 'List issues from a GitHub repository. Returns issue numbers, titles, states, labels, assignees, comment counts, timestamps, and a generated_at timestamp. Use to review open issues, track progress, or find specific issues by label.',
Expand All @@ -287,7 +286,6 @@ public function getListIssuesDefinition(): array
),
'required' => array( 'repo' ),
),
)
);
}

Expand Down
3 changes: 3 additions & 0 deletions tests/smoke-github-create-tools.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,9 @@ function is_wp_error( $thing ): bool
$assert('remove_label_from_issue is available in chat', in_array('chat', $github_tools->registered['remove_label_from_issue']['contexts'] ?? array(), true));
$assert('remove_label_from_issue is available in pipeline', in_array('pipeline', $github_tools->registered['remove_label_from_issue']['contexts'] ?? array(), true));

$list_issues_definition = $github_tools->getListIssuesDefinition();
$assert('list_github_issues uses default duplicate guard', 'repeatable' !== ( $list_issues_definition['runtime']['duplicate_policy'] ?? '' ));

$issue_definition = $issue_tool->getToolDefinition();
$issue_params = $issue_definition['parameters']['properties'] ?? array();
$assert('create_github_issue exposes assignees from ability schema', array_key_exists('assignees', $issue_params));
Expand Down
Loading