feat(is-user-core-member): overrides for CODEOWNERS #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the functionality from ExpediaGroup#706 to another helper
treyp
commented
Aug 22, 2025
| org: context.repo.owner, | ||
| team_slug: team, | ||
| per_page: 100 | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
replacement for this, but with pagination, added in #705
| export class IsUserCoreMember extends HelperInputs {} | ||
|
|
||
| export const isUserCoreMember = async ({ pull_number, login = context.actor }: IsUserCoreMember) => { | ||
| export const isUserCoreMember = async ({ pull_number, login = context.actor, codeowners_overrides }: IsUserCoreMember) => { |
Contributor
Author
There was a problem hiding this comment.
basically just bringing in the param, already defined in HelperInputs, to this helper
| export const getCoreMemberLogins = async (pull_number: number, teams?: string[]) => { | ||
| const codeOwners = teams ?? getCodeOwnersFromEntries(await getRequiredCodeOwnersEntries(pull_number)); | ||
| export const getCoreMemberLogins = async (pull_number: number, teams?: string[], codeowners_overrides?: string) => { | ||
| const codeOwners = teams ?? getCodeOwnersFromEntries(await getRequiredCodeOwnersEntries(pull_number, codeowners_overrides)); |
Contributor
Author
There was a problem hiding this comment.
getRequiredCodeOwnersEntries already supports codeowners_overrides thanks to #706, just need to pass forward the argument
Contributor
Author
|
replaced with #738 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Bring the
codeowners_overridesparameter introduced in #705 and #706 to another helper, this time to theis-user-core-memberhelper.