This repository was archived by the owner on Aug 1, 2025. It is now read-only.
Update binary-install dependencies to address CVE on axios#42
Open
Cellule wants to merge 1 commit intoEverlastingBugstopper:mainfrom
Open
Update binary-install dependencies to address CVE on axios#42Cellule wants to merge 1 commit intoEverlastingBugstopper:mainfrom
Cellule wants to merge 1 commit intoEverlastingBugstopper:mainfrom
Conversation
nahidakbar
approved these changes
Dec 6, 2023
|
Hey, any idea on when this PR will be merged? |
|
We'd also like to see this PR merged! I'm aware that most people run IMHO the bump of the minimum Node version to Node 14 is justifiable. Node 14 released more than four years ago, its support ended more than 550 days ago at the time of writing, so most users of this library that will bump their lock file are likely to be on Node 18 or newer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a vulnerability on axios
https://cve.mitre.org/cgi-bin/cvename.cgi?name=2023-45857
I also looked at updating the other dependencies.
This might require a major bump on binary-install since
rimrafdropped support for node 14 effectively making this project also requiring node 14+The other breaking changes on rimraf seemed minimal, only the removal of default export seems to affect this project.
It seems I also bumped the lockfile version, it should be a transparent change