Refactors bulk wiki find method for ranlkpage data

[AshakaE]

closes https://github.com/EveripediaNetwork/issues/issues/4624

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[gemini-code-assist]

Summary of Changes

Hello @AshakaE, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the MarketCapService to improve how wiki data is retrieved and processed in bulk for market capitalization features. The changes introduce a more modular and robust architecture for fetching, caching, and enriching wiki information, leading to better code readability and maintainability. Additionally, it enhances data integrity by ensuring unique market cap ID entries and using an upsert operation for saving these IDs.

Highlights

• Modularized Wiki Data Retrieval: The monolithic findWikisBulk method has been broken down into a series of smaller, more focused private methods (findWikis, checkCacheAndGetMissing, getIdMapping, fetchWikis, fetchWikisByIds, fetchWikisByCoingeckoUrl, enrichWikisWithRelatedData, collectRelatedIds, fetchRelatedData, buildEnrichedResults, cacheResults, mergeResults) to improve code organization and maintainability.
• Enhanced Cache Handling: The new structure explicitly checks the cache for existing wiki data and only fetches missing items, then caches the newly retrieved data, optimizing data access.
• Improved Data Fetching Logic: The wiki fetching process now intelligently handles cases where a wikiId is directly available or needs to be derived from a Coingecko profile URL, and also fetches related data (founders, blockchains, events) in a more structured way.
• Updated RankPageWiki Interface: The wiki property within the RankPageWiki interface now correctly allows for Wiki | null, reflecting scenarios where a wiki might not be found for a given ID.
• Database Integrity Improvements: The marketCapIds entity now enforces uniqueness on wikiId and coingeckoId columns, and the pin.service.ts uses upsert to prevent duplicate entries and handle conflicts gracefully when saving market cap IDs.
• Minor Adjustments: A new baseCoingeckoUrl constant was introduced, and a change was made in processMarketElement to access tags via wiki.__tags__ instead of wiki.tags.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request significantly refactors the logic for fetching wiki data for market cap rankings, breaking down a large, complex method into smaller, more focused functions. This greatly improves the code's structure, readability, and maintainability by leveraging TypeORM's QueryBuilder over raw SQL. While the refactoring is a positive step, I've identified several critical and high-severity issues related to correctness and performance that need to be addressed. These include a bug that could lead to runtime errors, an incorrect database schema definition for an upsert operation, and improper type assertions. Addressing these points will ensure the new implementation is not only cleaner but also robust and correct.