#1428 [List] fix: working column sort popover and invalid sortfield guard#1429
Merged
evarisk-kilyan merged 1 commit intoJun 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
Deux problèmes liés au tri par colonne des listes saturne :
replacedusortordersur le lien toggle).sortfieldpointant vers une colonne d'élément lié non triable (t.fk_product,disablesort) — resté dans l'URL ou la session « lastsearch » — faisait planter la requête (DB_ERROR_NOSUCHFIELD) avant le rendu, masquant toute la liste.Changements
js/modules/filter.jswindow.location(filtres/contexte préservés) :sortfieldlu sur le vrai lien de tri de la colonne,sortorderforcé,pageremis à 0,preventDefault/stopPropagation.disablesort, sans lien de tri) : pas de tri impossible proposé, donc aucune URL invalide générée.core/tpl/list/objectfields_list_build_sql_select.tpl.phpORDER BY: construction de l'ensemble des identifiants réellement produits par leSELECT(colonnest.xxx, alias calculés, extrafields) et abandon de toutsortfieldabsent de cet ensemble.sortfieldinvalide (URL/session périmée, signet) est purgé pour le reste de la page (formulaire + session) au lieu de planter. Protection valable pour toutes les listes saturne.Vérifications
php -lOK ; test unitaire de la garde sur leSELECTréel du contrôle (DROPt.fk_product/t.fk_soc; KEEPt.ref/t.date_creation/days_remaining_before_next_control/extrafields).js/saturne.min.jsnon commité (compilé par la CI sur push develop).Fichiers modifiés
js/modules/filter.jscore/tpl/list/objectfields_list_build_sql_select.tpl.phpIssue
Closes #1428