Conversation
…penAI class for improved message handling
…eordering imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the handling of context and message data across multiple modules, centralizing logic for token management and enhancing type safety. The changes include creating a new
CustomChatOpenAIclass for better token handling, replacingstrwith aContexttype in various states, and removing redundant truncation logic in favor of centralized token management.Key Changes
Token Management and Model Enhancements:
CustomChatOpenAIclass inprometheus/chat_models/custom_chat_openai.pyto handle token limits usingtiktoken_counter, ensuring input messages are trimmed safely. This class is now used inLLMServiceto replace the previousChatOpenAIintegration. [1] [2] [3]Context Type Migration:
Sequence[str]withSequence[Context]inBugReproductionState,ContextRetrievalState, andIssueClassificationStateto improve type safety and semantic clarity. [1] [2] [3]Contexttype, ensuring compatibility and proper formatting. [1] [2] [3]Message Truncation Simplification:
truncate_messagesutility and its usage in several nodes (BugReproducingWriteNode,ContextProviderNode,EditNode,IssueBugAnalyzerNode) as token management is now centralized inCustomChatOpenAI. [1] [2] [3] [4]String Conversion for Contexts:
Contexttype. [1] [2] [3] [4]Code Cleanup:
ContextRetrievalSubgraphNode, simplifying the codebase. [1] [2]These changes collectively improve maintainability, enhance type safety, and centralize token management, making the codebase more robust and easier to extend.