Skip to content

Dev#79

Merged
dcloud347 merged 11 commits into
mainfrom
dev
Jun 30, 2025
Merged

Dev#79
dcloud347 merged 11 commits into
mainfrom
dev

Conversation

@dcloud347

Copy link
Copy Markdown
Contributor

This pull request includes multiple changes across configuration files, service logic, and test cases to enhance performance, fix bugs, and improve code maintainability. Key changes include updates to Neo4j configurations for better memory and transaction handling, the removal of batch processing in the knowledge graph handler, and the correction of test cases and descriptions.

Configuration Updates:

  • Updated Neo4j memory and transaction settings in docker-compose.win_mac.yml and docker-compose.yml to increase heap size, transaction limits, and timeout values for improved performance. ([[1]](https://github.com/EuniAI/Prometheus/pull/79/files#diff-6cbb8d1e2560e17f87d3e842795d9d3c7c0af68434e7a64da008ce1441c740fbL13-R16), [[2]](https://github.com/EuniAI/Prometheus/pull/79/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L17-R17))
  • Removed network_mode: host from docker-compose.yml to align with container networking best practices. ([docker-compose.ymlL78](https://github.com/EuniAI/Prometheus/pull/79/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L78))

Service Logic Improvements:

  • Increased connection_timeout and max_transaction_retry_time in neo4j_service.py, and enabled keep_alive for more robust Neo4j connections. ([prometheus/app/services/neo4j_service.pyL11-R13](https://github.com/EuniAI/Prometheus/pull/79/files#diff-1b7b95ec8d8621479768687a5430d9cc6fb692c1a7cc150d131b58de109f2d54L11-R13))
  • Simplified the write_knowledge_graph method in knowledge_graph_handler.py by removing the _write_in_batches helper function and handling large datasets with explicit batching for PARENT_OF edges. ([prometheus/neo4j/knowledge_graph_handler.pyL186-R203](https://github.com/EuniAI/Prometheus/pull/79/files#diff-7ac522bd984256b8c6a9561999ccbfc32de117a42bf96c02eb1233661bbc0750L186-R203))

Bug Fixes:

  • Fixed typos in the description field of issue.py to correct "enviroment" to "environment." ([prometheus/app/api/issue.pyL55-R60](https://github.com/EuniAI/Prometheus/pull/79/files#diff-931c7c1aef0f188178bc2ad34720ed639d9bfeb50fb29364c3463f236e004807L55-R60))

Test Case Adjustments:

  • Updated test cases in test_issue_service.py to return None instead of an empty string for consistency in results. ([tests/app/services/test_issue_service.pyL148-R148](https://github.com/EuniAI/Prometheus/pull/79/files#diff-68a6f8958b8167c6bb7a619ab30b4129e1133967b15fd348c219c550604eaf77L148-R148))
  • Adjusted mock function names and parameters in test_llm_service.py to match updated APIs, ensuring test reliability. ([[1]](https://github.com/EuniAI/Prometheus/pull/79/files#diff-0eb7422b2d110005b5de48b5af5e87ed79a9dca017e618864c40db2cb49d7da8L58-R63), [[2]](https://github.com/EuniAI/Prometheus/pull/79/files#diff-0eb7422b2d110005b5de48b5af5e87ed79a9dca017e618864c40db2cb49d7da8L103-R109))

Miscellaneous:

  • Added MAX_TOKENS and TEMPERATURE settings in test_main.py to support new configuration options for testing. ([tests/app/test_main.pyR30-R31](https://github.com/EuniAI/Prometheus/pull/79/files#diff-b5c479f532726bbc0f67046b948b6423f023264e5e7dbe417e96ebf6308a6ccaR30-R31))

@dcloud347 dcloud347 merged commit 2199f7e into main Jun 30, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant