Conversation
…proved clarity and performance
…r improved performance
…delay to avoid overwhelming the database
…ng and improve clarity
…refactor knowledge graph edge writing to handle large batches with delays
…by standardizing spacing in batch slicing
… to 10 seconds for improved efficiency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes across configuration files, service logic, and test cases to enhance performance, fix bugs, and improve code maintainability. Key changes include updates to Neo4j configurations for better memory and transaction handling, the removal of batch processing in the knowledge graph handler, and the correction of test cases and descriptions.
Configuration Updates:
docker-compose.win_mac.ymlanddocker-compose.ymlto increase heap size, transaction limits, and timeout values for improved performance. ([[1]](https://github.com/EuniAI/Prometheus/pull/79/files#diff-6cbb8d1e2560e17f87d3e842795d9d3c7c0af68434e7a64da008ce1441c740fbL13-R16),[[2]](https://github.com/EuniAI/Prometheus/pull/79/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L17-R17))network_mode: hostfromdocker-compose.ymlto align with container networking best practices. ([docker-compose.ymlL78](https://github.com/EuniAI/Prometheus/pull/79/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L78))Service Logic Improvements:
connection_timeoutandmax_transaction_retry_timeinneo4j_service.py, and enabledkeep_alivefor more robust Neo4j connections. ([prometheus/app/services/neo4j_service.pyL11-R13](https://github.com/EuniAI/Prometheus/pull/79/files#diff-1b7b95ec8d8621479768687a5430d9cc6fb692c1a7cc150d131b58de109f2d54L11-R13))write_knowledge_graphmethod inknowledge_graph_handler.pyby removing the_write_in_batcheshelper function and handling large datasets with explicit batching forPARENT_OFedges. ([prometheus/neo4j/knowledge_graph_handler.pyL186-R203](https://github.com/EuniAI/Prometheus/pull/79/files#diff-7ac522bd984256b8c6a9561999ccbfc32de117a42bf96c02eb1233661bbc0750L186-R203))Bug Fixes:
descriptionfield ofissue.pyto correct "enviroment" to "environment." ([prometheus/app/api/issue.pyL55-R60](https://github.com/EuniAI/Prometheus/pull/79/files#diff-931c7c1aef0f188178bc2ad34720ed639d9bfeb50fb29364c3463f236e004807L55-R60))Test Case Adjustments:
test_issue_service.pyto returnNoneinstead of an empty string for consistency in results. ([tests/app/services/test_issue_service.pyL148-R148](https://github.com/EuniAI/Prometheus/pull/79/files#diff-68a6f8958b8167c6bb7a619ab30b4129e1133967b15fd348c219c550604eaf77L148-R148))test_llm_service.pyto match updated APIs, ensuring test reliability. ([[1]](https://github.com/EuniAI/Prometheus/pull/79/files#diff-0eb7422b2d110005b5de48b5af5e87ed79a9dca017e618864c40db2cb49d7da8L58-R63),[[2]](https://github.com/EuniAI/Prometheus/pull/79/files#diff-0eb7422b2d110005b5de48b5af5e87ed79a9dca017e618864c40db2cb49d7da8L103-R109))Miscellaneous:
MAX_TOKENSandTEMPERATUREsettings intest_main.pyto support new configuration options for testing. ([tests/app/test_main.pyR30-R31](https://github.com/EuniAI/Prometheus/pull/79/files#diff-b5c479f532726bbc0f67046b948b6423f023264e5e7dbe417e96ebf6308a6ccaR30-R31))