Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the test suite to improve compatibility with pytest's asyncio support and simplifies the usage of test fixtures. The most important changes are the removal of unnecessary
@pytest.mark.asynciodecorators and the refactoring of test fixture usage from asynchronous iteration to direct unpacking, making the tests cleaner and easier to read.Pytest configuration improvements:
pytest.iniby addingasyncio_mode = auto, ensuring better handling of async tests without explicit decorators.Test fixture usage simplification:
neo4j_container_with_kg_fixturefixture to unpack the fixture directly (neo4j_container, kg = neo4j_container_with_kg_fixture) instead of usingasync for, streamlining test code and improving readability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]Decorator cleanup:
@pytest.mark.asynciodecorators from async test functions, relying on the new pytest configuration for async test support. [1] [2] [3]Minor code formatting improvements:
These changes collectively make the test suite easier to maintain and ensure proper execution of async tests with pytest.