Conversation
…stead of a ServiceCoordinator
… and improve knowledge graph handling
…ng for answer_issue_log_dir
… to include new general settings
…rove service cleanup
…arity and service access
…arameter and clarify superuser creation
…e code formatting
…ructured response
…ise ServerException for error handling
…ter exception handlers
…ust assertion results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates, including environment configuration changes, API endpoint enhancements, and codebase simplifications. The most significant changes include adding new environment variables, refactoring API endpoints for authentication and repository management, and removing deprecated code. Below is a categorized summary of the most important changes:
Environment Configuration Updates
PROMETHEUS_ENVIRONMENT,PROMETHEUS_BACKEND_CORS_ORIGINS) and JWT authentication (PROMETHEUS_JWT_SECRET_KEY) in.github/workflows/pytest_and_coverage.yml,docker-compose.yml,docker-compose.win_mac.yml, andexample.env. [1] [2] [3] [4] [5] [6] [7] [8]API Endpoint Enhancements
loginendpoint inprometheus/app/api/auth.pyto facilitate user authentication and token generation.answer_issueendpoint inprometheus/app/api/issue.pyto use a new response model (Response[IssueResponse]) and updated service calls for improved modularity. [1] [2] [3]prometheus/app/api/repository.pyto improve error handling, modularity, and response consistency.Documentation Updates
README.mdto include instructions for generating a secure JWT secret key and corrected an API documentation link for the/issue/answer/endpoint. [1] [2]Codebase Simplification
create_db_and_tablesandcreate_superusermethods fromprometheus/app/db.py, as they are no longer required.ServiceCoordinatorclass with a dictionary-based service initialization inprometheus/app/dependencies.pyfor better modularity and maintainability.