-
-
Notifications
You must be signed in to change notification settings - Fork 20
GH-1212 Replace JetBrains annotations with JSpecify annotations for nullability #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully replaces JetBrains nullability annotations with JSpecify annotations across the project. The changes are thorough and consistent. I've added one suggestion to improve annotation correctness in one of the files, making the nullability contract more precise. Overall, this is a great refactoring that improves code standardization.
...e-core/src/main/java/com/eternalcode/core/bridge/placeholderapi/PlaceholderApiExtension.java
Outdated
Show resolved
Hide resolved
…ceholderapi/PlaceholderApiExtension.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
noyzys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trzeba też pamiętać jedno mieszanie adnotacji JetBrains i JSpecify mogłoby utrudnić interpretację kontraktów nullability, dlatego intencją jest pełne przejście na JSpecify w całym projekcie co za tym idzie zmiany w codebse.
Migracja do JSpecify jest celowa - chodzi o spójny, specyfikacyjny model nullability pseudo nullsafety i unikanie mieszania różnych frameworków adnotacji.
Twoja sugestia faktycznie poprawia precyzję kontraktu, więc ja daję approve aczkolwiek nie spamował bym tym na dużą skale.
Dlatego trzeba iść drogą hybrydową |
...e-core/src/main/java/com/eternalcode/core/bridge/placeholderapi/PlaceholderApiExtension.java
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/delay/InstantExpiry.java
Outdated
Show resolved
Hide resolved
...re-core/src/main/java/com/eternalcode/core/feature/adminchat/AdminChatChannelController.java
Outdated
Show resolved
Hide resolved
...re-core/src/main/java/com/eternalcode/core/feature/adminchat/AdminChatChannelController.java
Outdated
Show resolved
Hide resolved
...re-core/src/main/java/com/eternalcode/core/feature/adminchat/AdminChatChannelController.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/feature/adminchat/AdminChatCommand.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/feature/adminchat/AdminChatCommand.java
Outdated
Show resolved
Hide resolved
| NoticeService noticeService, | ||
| Notice message, | ||
| List<String> commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| NoticeService noticeService, | |
| Notice message, | |
| List<String> commands | |
| @NonNull NoticeService noticeService, | |
| @NonNull Notice message, | |
| @NonNull List<String> commands |
Co-authored-by: DMK <[email protected]>
Co-authored-by: DMK <[email protected]>
Co-authored-by: DMK <[email protected]>
Co-authored-by: DMK <[email protected]>
Co-authored-by: DMK <[email protected]>
Co-authored-by: DMK <[email protected]>
This PR replaces nullability annotations from JetBrains with the ones from JSpecify.
Resolves #1212