Make workspace publishable on crates.io - #249
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Cargo.toml files across several crates (surf-disco, tide-disco, and disco-types) to inherit repository and license-file settings from the workspace, specify explicit dependency versions, and add package descriptions. The reviewer pointed out that inheriting license-file from the workspace root will cause cargo publish to fail because Cargo resolves the license file path relative to each individual crate's directory. It is recommended to use license.workspace = true instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| authors.workspace = true | ||
| edition.workspace = true | ||
| repository.workspace = true | ||
| license-file.workspace = true |
There was a problem hiding this comment.
Inheriting license-file = "LICENSE" from the workspace root will cause cargo publish to fail for this crate. Cargo resolves license-file paths relative to the individual crate's directory (i.e., surf-disco/LICENSE), so it will fail to find the license file during packaging unless a copy exists in every sub-crate.
To fix this, it is highly recommended to use the license field (e.g., license = "MIT OR Apache-2.0") in the [workspace.package] section of the root Cargo.toml, and inherit it here using license.workspace = true.
| license-file.workspace = true | |
| license.workspace = true |
| edition.workspace = true | ||
| authors.workspace = true | ||
| repository.workspace = true | ||
| license-file.workspace = true |
There was a problem hiding this comment.
Inheriting license-file = "LICENSE" from the workspace root will cause cargo publish to fail for this crate. Cargo resolves license-file paths relative to the individual crate's directory (i.e., tide-disco/LICENSE), so it will fail to find the license file during packaging unless a copy exists in every sub-crate.
To fix this, it is highly recommended to use the license field (e.g., license = "MIT OR Apache-2.0") in the [workspace.package] section of the root Cargo.toml, and inherit it here using license.workspace = true.
| license-file.workspace = true | |
| license.workspace = true |
1 participant
No description provided.