fix(api): serve /version on every axum-migrated service - #4775
Draft
imabdulbasit wants to merge 1 commit into
Draft
fix(api): serve /version on every axum-migrated service#4775imabdulbasit wants to merge 1 commit into
imabdulbasit wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
tide-disco auto-registered an app-level /version next to /healthcheck on every service, so all of them answered it. The axum migration reproduced /healthcheck on each router but /version only on the espresso-node API, so the route 404s on the builder, orchestrator, state relay server, dev-node, light-client-query-service, node-metrics, hotshot-state-prover, submit-transactions and nasty-client. node-metrics lost /healthcheck too. Every service now routes /version to the shared handler in espresso-api; all workspace crates carry one version, so it reports the same value each binary would report itself. node-metrics gets both routes back.
imabdulbasit
force-pushed
the
ab/axum-app-level-version
branch
from
August 4, 2026 11:45
167bdf2 to
d39053c
Compare
Contributor
Nextest failures (1) in this run
See the step summary for flaky tests and slowest tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tide-disco auto-registered an app-level
/versionnext to/healthcheckon every service, so all of them answered it; the axum migration reproduced/healthcheckon each router but/versiononly on the espresso-node API, so the route now 404s on the builder, orchestrator, state relay server, dev-node, light-client-query-service, node-metrics, hotshot-state-prover, submit-transactions and nasty-client, and node-metrics lost/healthcheckas well. Anything polling/versionbreaks silently at cutover, since an unregistered route is not an error the server logs. The existing handler in espresso-api is nowpuband every service routes/versionto it directly; all workspace crates carry one version, so it reports the same value each binary would report itself. node-metrics gets both routes back.