This repository was archived by the owner on Feb 27, 2025. It is now read-only.
Add Membership Catchup Mechanism - #4109
Draft
bfish713 wants to merge 11 commits into
Draft
Conversation
ss-es
reviewed
Feb 12, 2025
| /// at the given block height | ||
| fn get_epoch_root( | ||
| &self, | ||
| block_height: u64, |
Contributor
There was a problem hiding this comment.
can this be epoch rather than block_height?
I think this is the only function in Membership that uses block_height currently, and I think we should be doing the conversion ourselves
| use super::node_implementation::NodeType; | ||
| use crate::{traits::signature_key::SignatureKey, PeerConfig}; | ||
|
|
||
| #[async_trait] |
Contributor
There was a problem hiding this comment.
what was the reason for removing async_trait and returning impl Futures?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: