PIL input handling in qreader/qrdet#53
Open
NaziaAfreen015 wants to merge 1 commit intoEric-Canas:mainfrom
Open
PIL input handling in qreader/qrdet#53NaziaAfreen015 wants to merge 1 commit intoEric-Canas:mainfrom
NaziaAfreen015 wants to merge 1 commit intoEric-Canas:mainfrom
Conversation
NaziaAfreen015
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qreader.detect_and_decode forwards PIL images to qrdet, which supports PIL for detection but not for crop_qr (expects NumPy). This mismatch breaks decoding when a PIL image is passed. Additionally, qrdet’s type check accepts PIL.ImageFile subclasses but not generic PIL.Image.Image (e.g., after Image.open(...).convert('RGB')), so valid PIL images are rejected.
Always convert PIL inputs to NumPy arrays in qreader.detect_and_decode before calling crop_qr.
Relax/normalize image-type checks in qrdet to accept generic PIL.Image.Image (not only PIL.*ImageFile subclasses).
Aligns qrdet behavior so that both Image.open(path) and Image.open(path).convert('RGB') are accepted.