radlink: prefer non-zero function prefixes for COMDAT Any - #939
Open
honkstar1 wants to merge 1 commit into
Open
Conversation
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prefer COMDAT
Anydefinitions with non-zero prefix data over definitions with no prefix or an all-zero prefix. LLVM places prefix data before the function entry point, whose COFF symbol value gives the prefix length. AutoRTFM uses this data to find the closed function variant; selecting an uninstrumented duplicate can discard that information.Null,Largest,SameSize, andAny/Largestpromotion unchanged.This is a standalone change against
dev(47de6bf), not a restacking of the existing optimization PRs.Validation
-O2) build.devand passes with this change.import_exportfails its export-offset assertion both before and after this patch in this environment; the baseline failure was reproduced separately.348ae713stack. Oodle-enabled optimized build: 181 passed, 0 failed/crashed, 1 excluded in the linker/torture/base/eval2 selection. The excluded case isms_link_icf_section_flag_eligibility, a Microsoft-linker comparison. Debugger and RDI suites were not part of that selection.348ae713binary.No production binaries have been replaced, and no Engine/runtime or farm soak result is claimed.