radlink: honor explicit library paths for bare DEFAULTLIB names - #934
Merged
NikitaSmith057 merged 1 commit intoSep 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An explicit
C:/sdk/lib/provider.libinput can be followed by/DEFAULTLIB:provider.lib, either on the command line or in an object's directives. IfC:/sdk/libis not onLIBPATH, radlink searches for the bare name again and warns that it cannot find a library it has already queued by full path. LLD recognizes the explicit input's basename.Fix
Keep a separate, case-insensitive basename table for explicitly supplied libraries. Consult it for default-library requests after the existing extension normalization and
/NODEFAULTLIBcheck. Do not strip directory components from a request and do not mix these aliases into the path-identity table.This preserves distinct explicitly named libraries and path-qualified defaults with identical basenames. Genuinely missing libraries still produce diagnostics; their existing warning/error severity is unchanged.
Standalone on
dev@0e2b7ed2: 17 implementation lines plus one regression test in the existing test file. No dependency on #842, #892, or #932.Validation
.lib.No MSVC compiler, linker, or assembler was invoked locally. The standalone tests require no proprietary SDK or compressed-object support. Full CI is separate from these focused checks.