Development#1280
Merged
Merged
Conversation
…-low-stock-settings
…unit validator for new block scheme
Bumps [org.apache.tika:tika-core](https://github.com/apache/tika) from 3.3.0 to 3.3.1. - [Changelog](https://github.com/apache/tika/blob/3.3.1/CHANGES.txt) - [Commits](apache/tika@3.3.0...3.3.1) --- updated-dependencies: - dependency-name: org.apache.tika:tika-core dependency-version: 3.3.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
… for intracting entity pojo
…ore-api/development/org.apache.tika-tika-core-3.3.1
…radle/software/core/oqm-core-api/development/org.apache.tika-tika-core-3.3.1 Bump org.apache.tika:tika-core from 3.3.0 to 3.3.1 in /software/core/oqm-core-api
…-low-stock-settings
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughArrr — InventoryItem.storageBlocks now hold structured StorageBlockSettings (schema bumped to v5); validation, schema-upgrade, services (stats/search/post-transaction), startup/indexing, UI, tests, docs, and version metadata updated to match. ChangesInventory per-block settings and schema v5
Estimated code review effort Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
|
Code Coverage
|
…xing ordering of db init operations
…ck unit input now updates with main item unit
sync indexes by key and drop by name
Code Coverage
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Code Coverage
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
software/libs/core-api-lib-quarkus/deployment/src/main/java/tech/ebp/oqm/lib/core/api/quarkus/deployment/CoreApiLibQuarkusProcessor.java (1)
77-79: ⚡ Quick winUse the known Mongo alias, matey, not the first alias off the list.
Line 138 pulls
getNetworkAliases().get(0), which is a brittle pick. Ye already defineMONGODB_DEVSERVICE_HOSTNAMEat Line 42; use that constant directly so the connection target stays steady if alias ordering changes.⚓ Proposed refactor
- ConfigureUtil.configureSharedNetwork(mongoDBContainer, "oqm-core-api-mongodb"); + ConfigureUtil.configureSharedNetwork(mongoDBContainer, MONGODB_DEVSERVICE_HOSTNAME); mongoDBContainer.withNetworkAliases(MONGODB_DEVSERVICE_HOSTNAME); @@ Map<String, String> props = Map.of( "host", - mongoDBContainer.getNetworkAliases().get(0), + MONGODB_DEVSERVICE_HOSTNAME, "port", "27017" //String.valueOf(mongoDBContainer.getMappedPort(27017)) );Also applies to: 136-141
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d61d5324-966b-4aba-9b8a-d6cb34772861
📒 Files selected for processing (7)
software/core/oqm-core-api/src/main/java/tech/ebp/oqm/core/api/health/service/StartupHealthCheck.javasoftware/core/oqm-core-api/src/main/java/tech/ebp/oqm/core/api/model/messaging/EventNotificationWrapper.javasoftware/libs/core-api-lib-quarkus/deployment/src/main/java/tech/ebp/oqm/lib/core/api/quarkus/deployment/CoreApiLibQuarkusProcessor.javasoftware/libs/core-api-lib-quarkus/deployment/src/main/java/tech/ebp/oqm/lib/core/api/quarkus/deployment/testContainers/OqmCoreApiWebServiceContainer.javasoftware/libs/core-api-lib-quarkus/deployment/src/test/java/tech/ebp/oqm/lib/core/api/quark/quarkus/test/CoreApiLibHealthCheckTest.javasoftware/libs/core-api-lib-quarkus/runtime/src/main/java/tech/ebp/oqm/lib/core/api/quarkus/runtime/messaging/EventNotificationWrapper.javasoftware/libs/core-api-lib-quarkus/runtime/src/main/java/tech/ebp/oqm/lib/core/api/quarkus/runtime/messaging/HistoryEventFilter.java
🚧 Files skipped from review as they are similar to previous changes (1)
- software/core/oqm-core-api/src/main/java/tech/ebp/oqm/core/api/health/service/StartupHealthCheck.java
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: CI-Pipeline / Unit Tests
Code Coverage
|
Code Coverage
|
…or host networking, to be done in #1287
Bumps [uk.org.okapibarcode:okapibarcode](https://github.com/woo-j/OkapiBarcode) from 0.5.5 to 0.5.6. - [Commits](woo-j/OkapiBarcode@v0.5.5...v0.5.6) --- updated-dependencies: - dependency-name: uk.org.okapibarcode:okapibarcode dependency-version: 0.5.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [uk.org.okapibarcode:okapibarcode](https://github.com/woo-j/OkapiBarcode) from 0.5.5 to 0.5.6. - [Commits](woo-j/OkapiBarcode@v0.5.5...v0.5.6) --- updated-dependencies: - dependency-name: uk.org.okapibarcode:okapibarcode dependency-version: 0.5.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ore-api/development/uk.org.okapibarcode-okapibarcode-0.5.6
Code Coverage
|
…radle/software/core/oqm-core-api/development/uk.org.okapibarcode-okapibarcode-0.5.6 Bump uk.org.okapibarcode:okapibarcode from 0.5.5 to 0.5.6 in /software/core/oqm-core-api
Code Coverage
|
…ore-base-station/development/uk.org.okapibarcode-okapibarcode-0.5.6
…radle/software/core/oqm-core-base-station/development/uk.org.okapibarcode-okapibarcode-0.5.6 Bump uk.org.okapibarcode:okapibarcode from 0.5.5 to 0.5.6 in /software/core/oqm-core-base-station
Code Coverage
|
Code Coverage
|
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Summary by CodeRabbit
New Features
Improvements
Documentation
Chores