Basico v2 support #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added explicit encoding="utf-8" to file open calls in omex.py and test_legacy.py to ensure consistent file reading across different environments.
Member
|
@fbergmann thanks for this PR and great to have |
JR-1991
requested changes
Sep 27, 2025
Member
JR-1991
left a comment
JR-1991
left a comment
There was a problem hiding this comment.
I have left a small comment to a typing issue. Other than that, everything looks and works great. Thanks!
Updated the 'inits' attribute in the ThinLayerCopasi class from a list of InitMap to a dictionary mapping strings to InitMap. This change likely improves lookup efficiency and clarifies the intended data structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making sure COPASI works with v2 (and v1)
This change is