Skip to content

feat(ui): add skeleton loading states to CampaignDashboard - #1224

Merged
Emmyt24 merged 1 commit into
Emmyt24:mainfrom
marvs8:feat/campaign-dashboard-skeleton-loading
Jun 5, 2026
Merged

feat(ui): add skeleton loading states to CampaignDashboard#1224
Emmyt24 merged 1 commit into
Emmyt24:mainfrom
marvs8:feat/campaign-dashboard-skeleton-loading

Conversation

@marvs8

@marvs8 marvs8 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Replaces the plain spinner in CampaignDashboard with a structured Skeleton layout that mirrors the real content (header row, meta grid, progress bar, steps list), consistent with the rest of the app.

Changes

  • CampaignDashboard.tsx: import Skeleton from ../UI/Skeleton; replace spinner div with a skeleton layout wrapped in a container with aria-label='Loading campaign'
  • CampaignDashboard.test.tsx: update loading state assertion from getByRole('status') to getByLabelText('Loading campaign')

Testing

  • Loading state test passes with the new skeleton assertion
  • 5 pre-existing failures (progressPercent.toFixed crash due to missing mock field) were already failing on main before this PR — no regressions introduced

Closes #1211

@drips-wave

drips-wave Bot commented Jun 1, 2026

Copy link
Copy Markdown

@marvs8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Emmyt24
Emmyt24 merged commit 4ddcc16 into Emmyt24:main Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ui): add skeleton loading states to CampaignDashboard component

2 participants