Skip to content

Make flow symptoms more visible by adjusting color #279#292

Merged
EmmaTellblom merged 2 commits intoEmmaTellblom:mainfrom
Jeevitha3:make-flow-symptoms-visible
Apr 6, 2026
Merged

Make flow symptoms more visible by adjusting color #279#292
EmmaTellblom merged 2 commits intoEmmaTellblom:mainfrom
Jeevitha3:make-flow-symptoms-visible

Conversation

@Jeevitha3
Copy link
Copy Markdown
Contributor

@Jeevitha3 Jeevitha3 commented Apr 2, 2026

Made flow symptoms visible by adding new pink color hues
Dark mode hex codes for the new pinks:
Light pink: CC95BB
Medium pink: B36098
Dark pink: 7E3366

I used the same color for both light and dark mode, as requested in the mockup.
Also, the symptom circles have outlines on the outside so that they are more visible.
On light mode, that color will be hex FFF6FF. On dark mode, that color will be hex 1E191F.

Related to the issue : #279

@Jeevitha3
Copy link
Copy Markdown
Contributor Author

Hi @EmmaTellblom,
Could you guide me how to add reviewer or How can i be added as a contributor to this project ?
I can see that it says Merging is blocked, unable to add a reviewer, and 1 workflow awaiting approval. I am not sure what other steps to do.
I'm new to Github open-source projects and I am interested into contributing to this project, because I myself use this application to have a secure period and ovulation tracking in my day-to-day life.

Please let me know if there are any prerequisites I am missing to do Github contribution in this project.
Thanks much! :)

@EmmaTellblom
Copy link
Copy Markdown
Owner

There are several issues that kind of relates to this, it's a bit confusing.
For example #292 and #139
I will check this more after Easter! I deleted my earlier comment. Thank you!

@EmmaTellblom
Copy link
Copy Markdown
Owner

@Jeevitha3
Ok, I have looked more closely at this and its a great first PR! There are just a few things to fix.

DatabaseUtils, this change is fine by me! It seems weird at first to change the function for Databaseversion7, but you are right that this is where we change the colors and its unnecessary to create another databaseUpgrade just for this. This change also makes sure that we dont change anything for current users, this will only effect new users which is perfect. Just wanted to explain this part :)

There is a bug currently with this PR though, and that is that the new colors do not show up in the colorPicker. And that is because the new colors are not 'grouped' together in ColorSource.kt which needs to be fixed. Otherwise they will not show up and user will not be able to select them. Look at row 18-28 in ColorSource.kt

Also, there is another bug in here that I had not seen before actually. And that is that the black, light gray and dark gray does not show up either. Could you perhaps fix that too?

1. Adding Pink shades to the color group picker.
2. Correcting the White, Black and gray colors to have similar naming conventions.
@Jeevitha3
Copy link
Copy Markdown
Contributor Author

Hi @EmmaTellblom,
Thanks much for your review! :) I have attached the UI changes after my changes. Kindly let me know if this is okay.
DarkThemeChanges
LightThemeChanges

@EmmaTellblom EmmaTellblom self-assigned this Apr 6, 2026
@EmmaTellblom EmmaTellblom self-requested a review April 6, 2026 15:12
@EmmaTellblom
Copy link
Copy Markdown
Owner

Approved!

@EmmaTellblom EmmaTellblom merged commit 1d4fe51 into EmmaTellblom:main Apr 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants