This repository was archived by the owner on Feb 18, 2021. It is now read-only.
Fix _clean_params in-place dictionary edit bug#16
Open
ZeArioch wants to merge 12 commits intoEmersonElectricCo:masterfrom
Open
Fix _clean_params in-place dictionary edit bug#16ZeArioch wants to merge 12 commits intoEmersonElectricCo:masterfrom
ZeArioch wants to merge 12 commits intoEmersonElectricCo:masterfrom
Conversation
**kwargs are passed as copies into functions, therefore _clean_params had no effect on the caller's kwargs dict. Refactored the code into _check_args which doesn't rely on modifying kwargs in-place
hacks introduced to support messagebus broke core features - restoring previous functioning setup for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for #12
Since Python doesn't like data structures changing while iterating over them, simply create a copy before processing.