feat: add fallback for invalid URL when combining with suffix #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a fallback mechanism when constructing a combined URL using
this.data.urland an optionalurlSuffix.Previously, if
this.data.urlwas invalid or not a proper base URL, the code would throw an exception without trying to use the suffix and fail to load the frame source.Now:
URLfromthis.data.url.This ensures frames still load even when the provided base URL is incomplete or invalid.
Also adds the ability to embed any website easily using the same configuration.
Use case
Risk