Add PocketChange UI for Monero wallet#5941
Open
claudinethelobster wants to merge 1 commit intoEdgeApp:developfrom
Open
Add PocketChange UI for Monero wallet#5941claudinethelobster wants to merge 1 commit intoEdgeApp:developfrom
claudinethelobster wants to merge 1 commit intoEdgeApp:developfrom
Conversation
- Create PocketChangeModal component with toggle and slider - Add English localization strings for PocketChange - Modal allows enabling/disabling and configuring pocket amount (0.1-1.3 XMR) - Integrates with Airship modal system Integration TODO: - Add modal trigger to Monero wallet settings/menu - Update SendScene to call wallet.otherMethods.getPocketChangeTargetsForSpend() - Show pocket breakdown in send confirmation - Save config to wallet.walletLocalData.pocketChangeSetting
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds UI components and localization for PocketChange feature. This PR provides the user-facing interface for configuring PocketChange settings. Requires: edge-currency-monero PR #101 for core functionality.
Changes
New Components
src/components/modals/PocketChangeModal.tsx:PocketChangeConfiginterfacesrc/locales/strings/enUS.json:Integration Requirements (Not Yet Implemented)
This PR provides the UI scaffolding. The following integration work is still needed:
1. Add Settings Menu Trigger
Option A: Wallet List Menu (Recommended)
Edit:
src/components/modals/WalletListMenuModal.tsxAdd menu item for Monero wallets:
Add action in
src/actions/WalletListMenuActions.ts:2. Integrate into Send Flow
Edit:
src/components/scenes/SendScene.tsxorSendScene2.tsxBefore creating the spend:
3. Update Send Confirmation UI
Edit:
src/components/scenes/SendConfirmationScene.tsxShow pocket breakdown:
Testing
After integration is complete:
Enable PocketChange:
Send Transaction:
Verify Immediate Spend:
Related
Files Modified
src/components/modals/PocketChangeModal.tsx- NEW (103 lines)src/locales/strings/enUS.json- 11 new stringsFiles Requiring Integration (TODO)
src/components/modals/WalletListMenuModal.tsxORsrc/components/scenes/CurrencySettingsScene.tsxsrc/actions/WalletListMenuActions.tssrc/components/scenes/SendScene.tsx(orSendScene2.tsx)src/components/scenes/SendConfirmationScene.tsxNotes
This PR is intentionally minimal (UI components only) to keep the review scope manageable. Integration work can be done as a follow-up or included before merge depending on preference.