Skip to content

Comments

Sync status#5931

Merged
swansontec merged 3 commits intodevelopfrom
william/sync-status
Feb 11, 2026
Merged

Sync status#5931
swansontec merged 3 commits intodevelopfrom
william/sync-status

Conversation

@swansontec
Copy link
Contributor

@swansontec swansontec commented Feb 9, 2026

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

EdgeApp/edge-core-js#702

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)
Simulator Screenshot - iPhone 16 Pro (normal) - 2026-02-09 at 15 34 53

Note

Medium Risk
Touches wallet-details UI and staking state shape (removing lockedNativeAmount), so regressions could affect displayed staking totals or syncing UX, but changes are localized and largely additive.

Overview
Adds a sync status warning card to TransactionListTop (wallet details header) while a wallet is syncing, including percent-complete and optional block progress, and animates it away shortly after sync completes.

Refactors TransactionListTop from a class/connected-style component into a hook-based functional component, removing the isLightAccount prop plumbing and updating tests accordingly.

Simplifies staking state management by removing lockedNativeAmount from Redux (StakingReducer + updateStakingState) and recomputing locked stake amounts locally from stakePositionMap; also tightens a few error handlers to use unknown and adds new locale strings (sync_status_title, sync_status_blocks).

Written by Cursor Bugbot for commit 9ab83ab. This will update automatically on new commits. Configure here.


@Jon-edge
Copy link
Contributor

Jon-edge commented Feb 9, 2026

Seems the currency changes also have some bugbot comments, I was unable to see the card in various currencies including ARR.

  1. Minor copy nit: The warning emoji in the title is essentially saying "Warning" literally, so this card reads like "Warning: Sync Progress." This title copy as written would make more sense if it was an info card: "Info: Sync Progress."

Suggest updating the title copy for the card to "Sync in Progress" since it does make sense to keep as a warning and this copy works better in a warning context

  1. Was the high decimal precision a requirement? It looks visually odd to have such high precision, but I admit that can be personal pref

  2. The WarningCard is also a legacy design, superseded by AlertCardUi4, could use a deprecation notice on WarningCard

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

})
}
}
}, [isSyncing])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale sync card state persists across wallet switches

Low Severity

The useEffect controlling showSyncCard depends only on [isSyncing], but the wallet can change without remounting the component (via navigation.setParams in the wallet list modal). When switching from a syncing wallet to a fully synced wallet, showSyncCard remains true for 1 second, causing the sync card to briefly flash "100% Complete" with a "Sync in Progress" title on the already-synced wallet before animating away.

Additional Locations (1)

Fix in Cursor Fix in Web

@swansontec swansontec merged commit 300fca7 into develop Feb 11, 2026
4 checks passed
@swansontec swansontec deleted the william/sync-status branch February 11, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants