Conversation
|
Seems the currency changes also have some bugbot comments, I was unable to see the card in various currencies including ARR.
Suggest updating the title copy for the card to "Sync in Progress" since it does make sense to keep as a warning and this copy works better in a warning context
|
b8210e3 to
edbba58
Compare
edbba58 to
5519b69
Compare
This is only used on the `TransactionListTop`, and can be cheaply computed using `useMemo`.
5519b69 to
9ab83ab
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| }) | ||
| } | ||
| } | ||
| }, [isSyncing]) |
There was a problem hiding this comment.
Stale sync card state persists across wallet switches
Low Severity
The useEffect controlling showSyncCard depends only on [isSyncing], but the wallet can change without remounting the component (via navigation.setParams in the wallet list modal). When switching from a syncing wallet to a fully synced wallet, showSyncCard remains true for 1 second, causing the sync card to briefly flash "100% Complete" with a "Sync in Progress" title on the already-synced wallet before animating away.


CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-core-js#702
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Medium Risk
Touches wallet-details UI and staking state shape (removing
lockedNativeAmount), so regressions could affect displayed staking totals or syncing UX, but changes are localized and largely additive.Overview
Adds a sync status warning card to
TransactionListTop(wallet details header) while a wallet is syncing, including percent-complete and optional block progress, and animates it away shortly after sync completes.Refactors
TransactionListTopfrom a class/connected-style component into a hook-based functional component, removing theisLightAccountprop plumbing and updating tests accordingly.Simplifies staking state management by removing
lockedNativeAmountfrom Redux (StakingReducer+updateStakingState) and recomputing locked stake amounts locally fromstakePositionMap; also tightens a few error handlers to useunknownand adds new locale strings (sync_status_title,sync_status_blocks).Written by Cursor Bugbot for commit 9ab83ab. This will update automatically on new commits. Configure here.