Add "Recent Wallets" to the top of the Wallet List when searching#5621
Merged
Add "Recent Wallets" to the top of the Wallet List when searching#5621
Conversation
swansontec
approved these changes
Jun 13, 2025
Contributor
swansontec
left a comment
swansontec
left a comment
There was a problem hiding this comment.
This is fine, but a bit weirdly complicated.
Comment on lines
+107
to
+122
| return list | ||
| .map((item, index) => ({ item, index })) | ||
| .sort((a, b) => { | ||
| if (a.item.type === 'asset' && b.item.type === 'asset') { | ||
| const keyA = `${a.item.wallet.id}_${(a.item.token?.currencyCode ?? a.item.wallet.currencyInfo.currencyCode).toLowerCase()}` | ||
| const keyB = `${b.item.wallet.id}_${(b.item.token?.currencyCode ?? b.item.wallet.currencyInfo.currencyCode).toLowerCase()}` | ||
|
|
||
| const pa = recentIndex[keyA] | ||
| const pb = recentIndex[keyB] | ||
| if (pa != null && pb != null) return pa - pb | ||
| if (pa != null) return -1 | ||
| if (pb != null) return 1 | ||
| } | ||
| return a.index - b.index | ||
| }) | ||
| .map(({ item }) => item) |
Contributor
There was a problem hiding this comment.
While this works, it's a weird way to do it. I would have done something more like this:
// Make a list of recent wallets:
let recentWallets = []
for (const {id, currencyCode} of mostRecentWallets) {
const item = list.find(...)
if (item != null) recentWallets.push(item)
}
// Put the recent wallets in the front:
return [
...recentWallets,
...list.filter(item => !recentWallets.includes(item))
]However, I do see that your way works, so this is just a suggestion. I still approve your version.
Jon-edge
force-pushed
the
jon/recent-wallets-list
branch
2 times, most recently
from
224135c to
cb37db6
Compare
Jon-edge
force-pushed
the
jon/recent-wallets-list
branch
from
cb37db6 to
dbbc2aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: