Conversation
Jon-edge
force-pushed
the
jon/change-username
branch
from
33d4ee3 to
658146c
Compare
swansontec
requested changes
Jun 13, 2025
| } | ||
|
|
||
| export function validatePassword(opts: ValidatePasswordOptions = {}): ThunkAction<Promise<boolean>> { | ||
| export function validatePassword(opts: ValidatePasswordOptions = {}): ThunkAction<Promise<string | undefined>> { |
Contributor
There was a problem hiding this comment.
Note for next time: This change would have made sense as its own commit.
Comment on lines
+21
to
+28
| const handleComplete = useHandler((result?: { username?: string | undefined }) => { | ||
| if (result?.username == null) return | ||
|
|
||
| account.changeUsername({ username: result.username, password }).catch(error => console.error(error)) | ||
| logActivity(`Username changed to: ${result.username}`) | ||
|
|
||
| navigation.goBack() | ||
| }) |
Contributor
There was a problem hiding this comment.
This logic should be in login-ui, similar to how change-pin or change-password work. Those basically just use login-ui directly with nothing more than a SceneWraper container around it.
swansontec
approved these changes
Jun 16, 2025
Jon-edge
force-pushed
the
jon/change-username
branch
2 times, most recently
from
ff0694e to
bcd8d4b
Compare
Jon-edge
force-pushed
the
jon/change-username
branch
from
bcd8d4b to
3630abb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: