Conversation
samholmes
approved these changes
Jun 3, 2025
peachbits
force-pushed
the
matthew/msw-poc
branch
from
d95d8df to
6b8d29c
Compare
Contributor
|
The maintainer updated https://www.npmjs.com/package/msw-snapshot so patch-package may not be needed if you can confirm it's included |
samholmes
force-pushed
the
matthew/msw-poc
branch
from
6b8d29c to
6573b52
Compare
samholmes
requested changes
Jun 6, 2025
Contributor
samholmes
left a comment
samholmes
left a comment
There was a problem hiding this comment.
I though this was good to go but then I as I was publishing there was a failed tests. I don't know how it ever worked with what jest is telling me.
I've made updates but to no avail
There are two snapshots because there are two rates servers and both need to be accounted for. Right now, this only adds snapshots for the rates servers. To add them globally across all tests, we can update the following fields in jest.config.js: setupFilesAfterEnv: ['./src/__mocks__/server.ts'], testEnvironment: 'node',
samholmes
force-pushed
the
matthew/msw-poc
branch
from
686025c to
5093583
Compare
samholmes
approved these changes
Jun 17, 2025
Contributor
samholmes
left a comment
samholmes
left a comment
There was a problem hiding this comment.
Fixed the issue by upgrading Jest. Seems like older version of Jest that we were using had a module resolution issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: