Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AGENTS.md
Outdated
|
|
||
| - **TypeScript**: Strict mode enabled, target ES2015, module ES2020 | ||
| - **Imports**: Use simple-import-sort, group by external/internal/relative | ||
| - **Formatting**: Prettier via eslint-config-standard-kit, 2-space indent, semicolons |
There was a problem hiding this comment.
"Prettier and Standard.js" might prompt better, and we don't use semicolons.
AGENTS.md
Outdated
| ## Code Style Guidelines | ||
|
|
||
| - **TypeScript**: Strict mode enabled, target ES2015, module ES2020 | ||
| - **Imports**: Use simple-import-sort, group by external/internal/relative |
There was a problem hiding this comment.
"group by external, then internal" is more correct.
AGENTS.md
Outdated
|
|
||
| ## Build/Test/Lint Commands | ||
|
|
||
| - **Test**: `npm test` (single test: `mocha test/path/to/file.test.ts`) |
There was a problem hiding this comment.
(single test: npm test test/path/to/file.test.ts)
src/util/swapHelpers.ts
Outdated
| for (const id of Object.keys(customFeeCacheMap)) { | ||
| if (Date.now() > customFeeCacheMap[id].timestamp + 30000) { | ||
| delete customFeeCacheMap[id] // eslint-disable-line | ||
| delete customFeeCacheMap[id]; // eslint-disable-line |
src/util/swapHelpers.ts
Outdated
| makeTxParams.unsignedTx, | ||
| makeTxParams.metadata |
There was a problem hiding this comment.
This seems wrong. The makeTx function takes MakeTxParams, which has a type field inside it. These two arguments shouldn't be broken out like this, but makeTxParams should be passed as-is.
| if (contractAddress === '0x0000000000000000000000000000000000000000') { | ||
| return null | ||
| } else { | ||
| const fakeToken: EdgeToken = { |
There was a problem hiding this comment.
// Pack the contractAddress into a dummy EdgeToken:
peachbits
force-pushed
the
matthew/bridgeless
branch
from
d3fe0b4 to
2668d08
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
peachbits
force-pushed
the
matthew/bridgeless
branch
from
2668d08 to
90ae4ad
Compare
2 participants
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-currency-accountbased#975
EdgeApp/edge-currency-plugins#439
Description
none