Open
Conversation
The items in the list are already known to need these changes, so there is no need to double-check.
This lets us control settings on a per-wallet basis, instead of per-chain (which is that the old userSettings property handles).
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| enabledTokenIds?: string[] | ||
| fiatCurrencyCode?: string | ||
| name?: string | ||
| walletSettings?: JsonObject |
There was a problem hiding this comment.
Wallet settings silently dropped during non-memory wallet creation
High Severity
walletSettings was added to EdgeCreateCurrencyWalletOptions and is correctly handled for memory wallets in memory-wallet.ts, but finishWalletCreation in keys.ts does not destructure or use walletSettings from opts. When a non-memory wallet is created via createCurrencyWallet or createCurrencyWallets with walletSettings, the settings are silently ignored and never persisted to disk via wallet.changeWalletSettings().
swansontec
force-pushed
the
william/wallet-settings
branch
from
09976ac to
1c29f48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Medium Risk
Introduces new persisted per-wallet state and new engine option/method wiring; mis-plumbing could break engine startup or cause settings to be dropped/overwritten, but it’s gated behind
hasWalletSettings.Overview
Adds a new wallet-scoped settings surface area:
EdgeCurrencyWallet.walletSettingspluschangeWalletSettings, gated by a newEdgeCurrencyInfo.hasWalletSettingsflag and persisted to a newWalletSettings.jsonfile.Plumbs these settings through core state/actions/reducer, loads them on wallet startup and reloads on repo changes, and forwards updates into engines via the new optional
EdgeCurrencyEngine.changeWalletSettings+ requiredEdgeCurrencyEngineOptions.walletSettings(also supported bymakeMemoryWallet). Also simplifies wallet-splitting restore logic to always callchangeWalletStateswhen restoring deleted/archived split wallets.Written by Cursor Bugbot for commit 1c29f48. This will update automatically on new commits. Configure here.