fix(managers): force-respawn OSDUIHelper on kickstart so native HUD stays suppressed at first launch#441
Open
nightah wants to merge 1 commit into
Open
fix(managers): force-respawn OSDUIHelper on kickstart so native HUD stays suppressed at first launch#441nightah wants to merge 1 commit into
nightah wants to merge 1 commit into
Conversation
…tays suppressed at first launch Pass `-k` to `launchctl kickstart` so launchd kills any running OSDUIHelper instance and respawns it cleanly before the subsequent SIGSTOP. Without `-k`, kickstart is a no-op when the service is already running, and the SIGSTOP can land on a lingering instance that macOS then replaces when a media key is pressed, leaving the native HUD visible on first launch until the user toggled the setting off and on again. With `-k`, the stop reliably applies to the freshly spawned process and the native HUD is suppressed immediately.
Owner
|
Hi @nightah , I believe the OSDUIHelper killing way is an old implementation, current one is basically supressing the HUDs by directly passing the data via the accessibility permissions. Let me know if I'm getting smth wrong |
Contributor
Author
|
@Ebullioscopic, you're right, and on further inspection and testing, I think the actual issue is that the I often have multiple HUDs appearing like below:
I find there are two ways to resolve this:
I'm not certain what is causing it not to work. I'll try to reproduce the issue and validate/update this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pass
-ktolaunchctl kickstartso launchd kills any running OSDUIHelper instance and respawns it cleanly before the subsequent SIGSTOP. Without-k, kickstart is a no-op when the service is already running, and the SIGSTOP can land on a lingering instance that macOS then replaces when a media key is pressed, leaving the native HUD visible on first launch until the user toggled the setting off and on again. With-k, the stop reliably applies to the freshly spawned process and the native HUD is suppressed immediately.