Remove DEFAULT_FILE_STORAGE from prod.py template — deploy-blocking conflict with regluit#1202 (STORAGES) - #61
Merged
Conversation
…gluit#1202) regluit#1202 moves file storage to the STORAGES dict in settings/common.py (required for Django 5.x, where DEFAULT_FILE_STORAGE is removed). Django 4.2 raises ImproperlyConfigured when DEFAULT_FILE_STORAGE and an explicit STORAGES are both set, so leaving this line in the rendered prod.py would 500 the site at boot the moment #1202 deploys. On 5.1+ the line would instead be silently ignored (dropping S3). Either way it must go, in the same deploy as #1202. The rendered value was identical to what common.py's STORAGES selects when AWS keys are present, so removal is behavior-neutral once #1202 lands. Found by Codex review of Gluejar/regluit#1203 (Django 5.2 spike), confirmed empirically (the exact ImproperlyConfigured was reproduced locally). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fm18PoiZmSo2iJGWHuVNm4
rdhyee
added
the
CC+Codex+LGTM
Contributor
Author
|
🤖 Codex review: LGTM. No Jinja issues; no remaining active |
rdhyee
added a commit
that referenced
this pull request
Jul 22, 2026
…p-prod.yml) Needed to render prod.py.j2 changes (e.g. #61 DEFAULT_FILE_STORAGE removal) onto test.unglue.it via the tagged config path instead of hand-editing. group_vars/test supplies the per-env vault values by group membership. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CZoSkYdkKLH37tH4QbEmH7
This was referenced Jul 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gluejar/regluit#1202 migrates file storage to the
STORAGESdict insettings/common.py(required for Django 5.x). The renderedprod.py(this template, line 175) still setsDEFAULT_FILE_STORAGEafter common.py loads:ImproperlyConfigured: DEFAULT_FILE_STORAGE/STORAGES are mutually exclusive→ whole-site 500 at boot the moment #1202 deploys. (Reproduced locally, exact error.)The rendered value is identical to what common.py's
STORAGESselects when AWS keys are present, so removal is behavior-neutral once #1202 lands.Deploy coordination: merge this and deploy (
--tags configrender of prod.py) in the same deploy window as regluit#1202 — #1202 must not reach test or prod while the old template line is live. Found by Codex review of the Django 5.2 spike (#1203).🤖 Generated with Claude Code
https://claude.ai/code/session_01Fm18PoiZmSo2iJGWHuVNm4