Create API for benchmark admin with date filter #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmandawibowo-vito
changed the title
JanssenBrm
requested changes
Oct 22, 2025
| const startDateParam = url.searchParams.get("start") || undefined; | ||
| const endDateParam = url.searchParams.get("end") || undefined; | ||
|
|
||
| const dateValidation = validateDateParameters(startDateParam, endDateParam); |
There was a problem hiding this comment.
Some of this code is duplicated in the other endpoint. Maybe we can create some helper functions to ensure the same logic is properly applied?
There was a problem hiding this comment.
I have moved the duplicated logic to lib/parquet-datasource.ts in this commit , I think the file is suitable to contain such logic. 51d8b9c. Wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ref: #18
New APIs are introduced for benchmark date filtering. The authorization logic will be added in a separated PR.
GET /api/admin/services/benchmarks.json
GET /api/admin/services/{id}/benchmarks.json