[CFG] Traverse through shrsi in GIID check#975
Merged
Conversation
The GIID implementation uses a white-list of operations to traverse which `shrsi` was previously not part of. This would lead to e.g. data dependencies not correctly being found and used to eliminate memory ordering dependencies. Fixes #974
Jiahui17
reviewed
Jun 15, 2026
| handshake::SubIOp, handshake::TruncIOp, handshake::XOrIOp, | ||
| handshake::AddFOp, handshake::CmpFOp, handshake::DivFOp, | ||
| handshake::MulFOp, handshake::SubFOp>([&](auto) { | ||
| handshake::ShRSIOp, handshake::SubIOp, handshake::TruncIOp, |
Member
There was a problem hiding this comment.
Maybe do:
// clang-format off
<
handshake::ShRSIOp,
handshake::TruncIOp,
...
>
// clang-format on
Collaborator
Author
There was a problem hiding this comment.
I admittedly prefer to have clang-format here also because the list would get quite long otherwise
Jiahui17
approved these changes
Jun 15, 2026
Collaborator
|
my literal exact fears looking at that code come true 😭😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GIID implementation uses a white-list of operations to traverse which
shrsiwas previously not part of. This would lead to e.g. data dependencies not correctly being found and used to eliminate memory ordering dependencies.Fixes #974