[codex] fix coding agent model switching#1725
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes coding agent session model switching so Claude/Codex sessions can switch provider/model without carrying stale runtime configuration from the previous provider.
Changes
baseUrl/apiKeyfrom being reused after coding agent provider changes, with a backend guard for mismatched builtin provider endpoints.Root Cause
Coding agent sessions stored provider runtime fields such as
baseUrlandapiKeyin frontend session memory. After switching provider/model, continuing without a page refresh could still send the previous provider endpoint, for exampleprovider=deepseekwith a Xiaomi base URL. The backend then generated a new Codex home for DeepSeek but registered the proxy against the stale upstream endpoint.Validation
npm exec -- vitest run tests/client/chat-store-reasoning-tool-boundary.test.ts tests/client/chat-panel-session-click.test.ts tests/server/coding-agent-resume-config.test.ts tests/server/handle-coding-agent-run.test.ts tests/server/sessions-controller.test.tsnpm exec -- vitest run tests/client/chat-panel-session-click.test.ts tests/server/sessions-controller.test.ts tests/server/coding-agent-resume-config.test.ts tests/server/run-chat-bridge-final-context.test.tsnpm run harness:checknpm run build