use is_ci_test in place of bench_name_ci #301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoors
changed the title
smoors
changed the title
casparvl
reviewed
Dec 22, 2025
| def set_tag_ci(self): | ||
| """Set tag CI on smallest benchmark, so it can be selected on the cmd line via --tag CI""" | ||
| if self.benchmark_info[0] == 'hackathonGPU/benchmark': | ||
| self.tags.add(TAGS.CI) |
Collaborator
There was a problem hiding this comment.
I was completely puzzled: MetalWalls wasn't showing up if I did -t CI after your change. The issue is that MetalWalls does not inherit from EESSI_mixin. We should probably do that - but probably in a separate PR.
I'd just revert the change here, as self.is_ci_test is only respected by tests that inherit from EESSI_mixin.
Collaborator
Author
There was a problem hiding this comment.
ah right, will revert
added 2 commits
December 25, 2025 20:18
Collaborator
|
Discussed in sync meeting: @casparvl will re-review by rerunning the tests. If those pass, it's good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_ci_testis simpler than having to set bothbench_nameandbench_name_ci.it's also easier to understand and to explain :)
see also the companion docs PR:
is_ci_testinstead ofbench_name_cidocs#623