Exclude default modules from searches on inara#854
Open
token419 wants to merge 1 commit intoEDCD:developfrom
Open
Exclude default modules from searches on inara#854token419 wants to merge 1 commit intoEDCD:developfrom
token419 wants to merge 1 commit intoEDCD:developfrom
Conversation
This builds a list of the default modules and then removes them from the current loadout, leading to more accurate searches on inara. An example where the current system can lead to less accurate results is, when searching a default ship, the hull armor is included, and many more stations may sell the ship than sell the hull armor for the ship, but the hull armor comes default when you buy the ship, even if the station does not sell the hull armor. The above scenario could happen for any particular E class module as well, where it comes on the ship, but the station itself may not sell it, so therefore would not be a candidate in the current search string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds a list of the default modules and then removes them from the current loadout, leading to more accurate searches on inara.
An example where the current system can lead to less accurate results is, when searching a default ship, the hull armor is included, and many more stations may sell the ship than sell the hull armor for the ship, but the hull armor comes default when you buy the ship, even if the station does not sell the hull armor.
The above scenario could happen for any particular E class module as well, where it comes on the ship, but the station itself may not sell it, so therefore would not be a candidate in the current search string.