Feat/drowning #177
Open
Feat/drowning #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensku
reviewed
Mar 8, 2021
| /** | ||
| * Calculate the weight of the inventory/player | ||
| */ | ||
| function getWeight(swimmer: Player) { |
Contributor
There was a problem hiding this comment.
I'm a bit worried about performance of this if there are many players online.
| }); | ||
| }, 300); | ||
|
|
||
| // Weight for each armor piece player is using |
| import { ItemStack } from 'org.bukkit.inventory'; | ||
| import { minMax } from '../common/helpers/math'; | ||
|
|
||
| // Min weight to start drowning (with minimum force) |
Contributor
There was a problem hiding this comment.
When writing comments for variables like here, use JSDoc so that they also get editor tooltips.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.