[Node] fix multiple template+CSV+manual edit import issues - #3645
Open
GuillaumeDSM wants to merge 1 commit into
Open
[Node] fix multiple template+CSV+manual edit import issues#3645GuillaumeDSM wants to merge 1 commit into
GuillaumeDSM wants to merge 1 commit into
Conversation
Herklos
reviewed
Aug 14, 2026
| unmappedColumns: number[], | ||
| ): number[] { | ||
| const nameColumnIndex = headers.findIndex( | ||
| (header) => header.trim().toLowerCase() === "name", |
Contributor
There was a problem hiding this comment.
Shouldn't we prefer a param for header col name and so have filterFromUnmappedColumns instead of filterNameFromUnmappedColumns
Herklos
reviewed
Aug 14, 2026
| rows: string[][], | ||
| detectionResults: ReturnType<typeof detectColumnsAndTemplates>, | ||
| ): ActionRow[] { | ||
| const nameIdx = headers.findIndex((h) => h.trim().toLowerCase() === "name") |
GuillaumeDSM
force-pushed
the
node_import
branch
from
August 14, 2026 16:49
0da136d to
a7ef8bb
Compare
Member
Author
|
thanks, it's up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blockchain_fromcell + XXX templateblockchain_fromunmapped