updates and fixes mounted guns, makes the example weapon more usable - #1198
Open
carda-sometimesknownas-paxilmaniac wants to merge 3 commits into
Open
updates and fixes mounted guns, makes the example weapon more usable#1198carda-sometimesknownas-paxilmaniac wants to merge 3 commits into
carda-sometimesknownas-paxilmaniac wants to merge 3 commits into
Conversation
carda-sometimesknownas-paxilmaniac
requested review from
00-Steven,
TheOneAndOnlyCreeperJoe and
desertmote
as code owners
September 3, 2026 10:36
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes multiple aspects of mounted guns that were broken in some way or another, such as being unable to complete click actions on the weapon in any way while it was mounted.
Gives mounted guns some new features, such as throwing casings aside to reduce incidents of giant piles of casings underneath the weapon.
Updates the example weapon to something higher quality to strive for, the Yanao tripod machinegun from a prior PR that I'm atomizing.
2026-08-13.23-50-38.mp4
Why It's Good For The Game
Code working as intended is usually better for the codebase.
Right now the example for mounted guns isn't very usable and doesn't really demonstrate what all the component for mounted weapons can do. The tripod machinegun should better demonstrate what can be done with the system to prospective contributors.
Changelog
🆑
add: Adds the Yanao tripod machinegun as a better example to represent what the mounted weapons system is capable of
qol: Weaponry can now eject casings in a direction rather than directly under the shooter, if desired
fix: Fixes multiple bugs with mounted guns
/:cl: