Skip to content

Multiple flaky test failures in create_and_destroy, dcs_check_list_arguments #1206

Description

@github-actions

Flaky tests were detected in this test run. This means that there was a failure that was cleared when the tests were simply restarted.
Failures:

create_and_destroy: [21:38:55] Runtime in code/modules/reagents/reagent_containers/condiment.dm,28: Cannot read null.len
proc name: update icon state (/obj/item/reagent_containers/condiment/update_icon_state)
src: the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration)
src.loc: the floor (126,126,15) (/turf/open/floor/iron)
call stack:
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): update icon state()
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): update icon(16777215)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): update appearance(16777215)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): on reagent change(/datum/reagents (/datum/reagents))
/datum/reagents (/datum/reagents):  SendSignal("reagents_update_total", /list (/list))
/datum/reagents (/datum/reagents): update total()
/datum/reagents (/datum/reagents): end reaction(/datum/equilibrium (/datum/equilibrium))
/datum/reagents (/datum/reagents): force stop reacting()
/datum/reagents (/datum/reagents): Destroy(0)
qdel(/datum/reagents (/datum/reagents), 0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
qdel(the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration), 0)
/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run()
RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list))
RunUnitTests()
/datum/callback (/datum/callback): InvokeAsync() at code/modules/reagents/reagent_containers/condiment.dm:28
create_and_destroy: [21:38:55] Runtime in code/modules/reagents/reagent_containers/condiment.dm,28: Cannot read null.len
proc name: update icon state (/obj/item/reagent_containers/condiment/update_icon_state)
src: the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration)
src.loc: the floor (126,126,15) (/turf/open/floor/iron)
call stack:
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): update icon state()
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): update icon(16777215)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): update appearance(16777215)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): on reagent change(/datum/reagents (/datum/reagents))
/datum/reagents (/datum/reagents):  SendSignal("reagents_update_total", /list (/list))
/datum/reagents (/datum/reagents): update total()
/datum/reagents (/datum/reagents): end reaction(/datum/equilibrium (/datum/equilibrium))
/datum/reagents (/datum/reagents): force stop reacting()
/datum/reagents (/datum/reagents): Destroy(0)
qdel(/datum/reagents (/datum/reagents), 0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
qdel(the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration), 0)
/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run()
RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list))
RunUnitTests()
/datum/callback (/datum/callback): InvokeAsync() at code/modules/reagents/reagent_containers/condiment.dm:28
create_and_destroy: [21:38:55] Runtime in code/modules/reagents/reagent_containers/condiment.dm,28: Cannot read null.len
proc name: update icon state (/obj/item/reagent_containers/condiment/update_icon_state)
src: the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration)
src.loc: the floor (126,126,15) (/turf/open/floor/iron)
call stack:
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): update icon state()
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): update icon(16777215)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): update appearance(16777215)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): on reagent change(/datum/reagents (/datum/reagents))
/datum/reagents (/datum/reagents):  SendSignal("reagents_update_total", /list (/list))
/datum/reagents (/datum/reagents): update total()
/datum/reagents (/datum/reagents): finish reacting()
/datum/reagents (/datum/reagents): force stop reacting()
/datum/reagents (/datum/reagents): Destroy(0)
qdel(/datum/reagents (/datum/reagents), 0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration): Destroy(0)
qdel(the frozen small sugar sack (/obj/item/reagent_containers/condiment/sugar/small_ration), 0)
/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run()
RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list))
RunUnitTests()
/datum/callback (/datum/callback): InvokeAsync() at code/modules/reagents/reagent_containers/condiment.dm:28
dcs_check_list_arguments: Found 2 datum list arguments with similar contents for /datum/element/give_turf_traits. Contents: ["turf_ignore_slowdown","turf_ignore_slippery","immerse_stopped"]. at code/modules/unit_tests/dcs_check_list_arguments.dm:51
dcs_check_list_arguments: Ensure that each list is static or cached. string_list() (as well as similar procs) is your friend here.
Check the documentation from dcs_check_list_arguments.dm for more information! at code/modules/unit_tests/dcs_check_list_arguments.dm:55

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions