infra: silence nag when dev3 lights are off#2985
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the dev3 service is scaled to zero by the lights-out flow, the Route53 health-check alarm predictably transitions to ALARM and — because it matches the
${env}-${service}-*-Extended-*wildcard — triggers the nag pipeline (EventBridge → Step Function → SNScriticaltopic → 5-minute re-page loop). This PR gates that pipeline on lights state so scheduled downtime doesn't page on-call.What changed
LightsOutlambda now callsevents.disable_rule(in us-east-1) on the${env}-${service}-nag-extended-alarmsEventBridge rule — the rule that forwards alarm state-change events from us-east-1 to the us-east-2 default event bus. Once disabled, no state-change events reachNagStateMachine, so no SNS notifications fire.LightsOnlambda re-enables the rule.events:DisableRuleandevents:EnableRule.Silencing at the forwarding-rule level (rather than the alarm's
AlarmActions) is what actually stops the nag: EventBridgeCloudWatch Alarm State Changeevents fire regardless ofActionsEnabled, soDisableAlarmActionsalone would have left the nag intact.Test plan
Verified on dev3:
ENABLED(aws events describe-rule --name dev3-doenet-nag-extended-alarms --region us-east-1).DISABLED.dev3-nag-state-machineexecutions start and no critical SNS notification is delivered.ENABLED, LightsOn lambda logs clean.