fix(ui): stretch NameBar in folder view flex column#2966
Open
cqnykamp wants to merge 1 commit into
Open
Conversation
The NameBar's `width: 100%` was enough to stretch it inside the editor's
HStack parent, but not inside the folder view's `<Flex flexDirection={{
base: "column", md: "row" }}>`. Adding `flex={1}` to the outer Box (both
read-only and editable branches) and the Editable lets the NameBar fill
the available row/column space in both flex contexts.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the folder view page, the NameBar (gray title bar) collapsed to the width of its text instead of stretching to fill its row like it does on the editor page.
Fix
NameBar.tsxalready setwidth: 100%, which stretched it inside the editor's<HStack>but not inside the folder view's<Flex flexDirection={{ base: "column", md: "row" }}>(parent doesn't constrain a definite width on the cross axis when its own width is content-driven). Addedflex={1}to the outer Box (both read-only and editable branches) and the innerEditableso it fills available row/column space in both flex contexts.Test plan
NameBar.cy.tsxcomponent tests still pass (15/15)